Skip to content

Rollback job references empty uses: for inline-run deploys with rollback_on_failure #120

Description

@joshua-temple

The generated promote rollback job (internal/generate/promote.go writeRollbackJobs) always emits uses: <deploy.Workflow>, with no inline-run branch (unlike writeDeployJobs, which supports a run: callback). A manifest that combines an inline run: deploy callback with rollback_on_failure therefore emits a rollback job referencing an empty workflow path, producing broken YAML at rollback time. Either emit an inline-run rollback branch mirroring the deploy job, or validate that rollback_on_failure requires reusable-workflow deploys. Found during e2e rollback-runtime scenario work (PR #118).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions