fix: stop asserting the no-change build-skip on the live fleet - #271
Merged
Merged
Conversation
Producing a genuinely change-free orchestrate dispatch on the live fleet is unreliable: the dispatch SHA advances past the last finalized envState.SHA, so cascade correctly detects a change and runs the build (verified: the underlying skip behaviour is correct and fixed in stablekernel/cascade#351). The skip is proven deterministically at the right layers (the internal/orchestrate unit tests and the act+gitea scenario 06-no-change-skip). Step 12 keeps the live concurrency-cancel assertions and the no-change run-concludes-success check. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Producing a genuinely change-free dispatch on the live fleet is unreliable (the dispatch SHA advances past the finalized envState.SHA, so cascade correctly runs the build). The skip behaviour is correct and fixed in stablekernel/cascade#351, and proven deterministically by the internal/orchestrate unit tests plus the act+gitea scenario
06-no-change-skip.yaml. Step 12 keeps its live concurrency-cancel assertions and the no-change run-concludes-success check.