Skip to content

fix: fixed pending spec formatter#89

Merged
st0012 merged 2 commits into
st0012:mainfrom
D-system:pending_spec_fix
Sep 13, 2025
Merged

fix: fixed pending spec formatter#89
st0012 merged 2 commits into
st0012:mainfrom
D-system:pending_spec_fix

Conversation

@D-system
Copy link
Copy Markdown
Contributor

@D-system D-system commented Aug 8, 2025

In case of a pending spec, the third argument is not provided.

Here's a sample for the parts variable:

["./spec/models/report_spec.rb", "137"]
["./spec/models/report_spec.rb", "150", "in 'block (4 levels) in <top (required)>'"]
["./spec/rails_helper.rb", "122", "in 'block (2 levels) in <top (required)>'"]

The top entry is a pending spec.

In case of a `pending` spec, the third argument is not provided.
@D-system D-system changed the title Fix pending spec for rspec_formatter.rb fix: pending spec formatter Aug 8, 2025
@st0012
Copy link
Copy Markdown
Owner

st0012 commented Sep 7, 2025

Thanks for the PR, can you also add a test for this case?

@D-system
Copy link
Copy Markdown
Contributor Author

@st0012 Thanks Stan for pointing to the right spec file. The test is added. The issue was in a fixed pending spec.

@D-system D-system changed the title fix: pending spec formatter fix: fixed pending spec formatter Sep 11, 2025
Copy link
Copy Markdown
Owner

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@st0012 st0012 added the bug Something isn't working label Sep 13, 2025
@st0012 st0012 merged commit d710654 into st0012:main Sep 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants