Skip to content

cleanup constants#7

Open
shubhamgoenka wants to merge 1 commit into
masterfrom
cleanup
Open

cleanup constants#7
shubhamgoenka wants to merge 1 commit into
masterfrom
cleanup

Conversation

@shubhamgoenka

Copy link
Copy Markdown
Collaborator

No description provided.

/******/
/******/ // __webpack_public_path__
/******/ __webpack_require__.p = "/Users/ssuresh/Desktop/fun-night/templates/public";
/******/ __webpack_require__.p = "/Users/shubham/repo/fun-night/templates/public";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be computer agnostic

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssuresh2dev what should this be

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this file should be in the .gitignore lol it gets autogenerated when you run npm scripts

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just a compiled version of all the React code into a single bundle so that it's easier for the browser to download

@ssuresh2dev ssuresh2dev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge without rebasing, there will be conflicts because I removed bundle.js from the git repo and added it to .gitignore. You'll need to go to master and pull first and then git checkout cleanup and git rebase master. When you get the merge conflict go ahead and delete bundle.js and run git rebase --continue. Then push again with git push origin cleanup --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants