⚡ Optimize pre-bash danger guard by avoiding subprocesses#13
Conversation
I replaced the external search pipeline with the built-in bash string substring match `[[ "$CMD" == *"$DANGER"* ]]` along with `shopt -s nocasematch`. This dramatically speeds up the pre-bash guard execution and reduces the overhead of spawning 14 subprocesses. Co-authored-by: sstklen <90471971+sstklen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Replaced
echo "$CMD" | grep -qiF "$DANGER"with bash built-in string substring match ([[ "$CMD" == *"$DANGER"* ]]) inside the danger checking loop.🎯 Why:
The previous approach spawned at least two subprocesses (
echoandgrep) for every dangerous command string checked (14 times per hook execution). Using bash's built-in string evaluation natively removes this overhead, substantially speeding up script evaluation before AI bash commands. Backwards compatibility for Bash 3.2 (macOS) was preserved by usingshopt -s nocasematchinstead of bash 4.0 parameter expansions.📊 Measured Improvement:
Benchmarked locally by running 1,000 iterations:
PR created automatically by Jules for task 1766001118522006068 started by @sstklen