Repository navigation
CMake: build DocumentQueue.cpp once in doculith_core, link executable against it - #12
Closed
sromic1990 with Copilot wants to merge 2 commits into
Closed
sromic1990 with Copilot wants to merge 2 commits into
sromic1990 with Copilot wants to merge 2 commits into
Conversation
…th against doculith_core Co-authored-by: sromic1990 <13477194+sromic1990@users.noreply.github.com> Agent-Logs-Url: https://github.com/sromic1990/Doculith/sessions/cfa49bab-be9d-475f-8f21-6eab0eac62df
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on file management handling features
CMake: build DocumentQueue.cpp once in doculith_core, link executable against it
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentQueue.cppwas compiled into both thedoculithexecutable and thedoculith_corelibrary, duplicating compilation and creating a drift risk between the two build targets.Changes
doculith_coreis now declared beforedoculithto reflect the dependency directionDocumentQueue.cppremoved fromdoculithsources; built only indoculith_coredoculith_coreusesPUBLICfor bothtarget_include_directories(src)andtarget_link_libraries(nfd), so dependents get headers andnfdautomaticallydoculithlinks againstdoculith_coreinstead of listingnfddirectly📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.