Repository navigation
Make AppModel.h self-contained by adding missing standard headers - #10
Merged
sromic1990 merged 2 commits intoMar 21, 2026
Merged
Conversation
…pModel.h Co-authored-by: sromic1990 <13477194+sromic1990@users.noreply.github.com> Agent-Logs-Url: https://github.com/sromic1990/Doculith/sessions/75c0e793-22fe-4ef3-91c9-c148549d160b
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on file management handling in core feature PR
Make AppModel.h self-contained by adding missing standard headers
Mar 21, 2026
sromic1990
marked this pull request as ready for review
March 21, 2026 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppModel.husedstd::string,std::min, andstd::memcpywhile relying on transitive includes fromDocumentQueue.hto satisfy them — fragile under-Wall -Wextra -Werror -Wpedanticbuilds where missing direct includes can break compilation.Changes
src/AppModel.h: Added explicit includes for the three standard headers the file directly depends on:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.