Repository navigation
Let a server form take readers off a list; give app sign-ups their own list - #2
Merged
Merged
Conversation
…n list - POST /unsubscribe: a form with a key takes an address off one of its lists and suppresses it there, so the app's newsletter toggle works. Same answer whether or not the address was on the list; never from a browser. - config/sourceful.json: list app-users and form sourceful-app, so accounts the app signs up stay apart from The Source until someone decides. - The bounce webhook test looked for msg-2, but a batch sends in parallel; it now looks up the recipient's message id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mailchimp is gone, so the website, the app and FTW move their sign-ups to Utskick. This is Utskick's part.
POST /unsubscribe: a form with a key takes an address off one of its lists and suppresses it there. The Sourceful app's newsletter toggle needs it. The answer is the same whether or not the address was on the list. Browser forms cannot use it. There is still no call that says whether an address is on a list.app-userslist andsourceful-appform inconfig/sourceful.json: the app signs up every new account, so those addresses go to a list of their own, apart from The Source, until someone decides what they get.msg-2, but a batch sends in parallel. It now looks up the message id.Docs:
docs/signup.mddescribes/unsubscribe.Tests: 209 pass, typecheck passes.
🤖 Generated with Claude Code