Repository navigation
Conversation
Signed-off-by: Segran <goran@andersson-stehag.se>
segran2
marked this pull request as ready for review
November 6, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Fixes #1976. A car that has stopped at its own charge limit can draw 0 W while Core still asks for charging because vehicle SoC is missing or stale. The driver already reports
request_active=false, but feedback could still saynot_following/no_power_responseand optional recovery could restart the vehicle.This change uses that existing, explicit driver signal to explain “The charger reports that the car has finished or paused charging”, with a prompt to check the car's charge limit and schedule. It never infers a full battery, rewrites SoC or marks the charging goal complete.
vehicle_not_requesting/waiting/info.ControlStatesuses the same result, socontrol.not_followingdoes not fire solely on this explained zero draw.RequestKnowndistinguishes explicit vehicle refusal from legacy telemetry without the field. Optional resume and vehicle-wake retries are avoided while the current vehicle explicitly declines power. Normal recovery returns when the vehicle requests charging again.vehicle_request_activeis an additive optional feedback field. A patch changeset is included.Validation
On this standalone branch based on
ec8ce36192cfe9947b63f7ed9e388c28ecc375a5:make verify: passed. Docker-daemon-dependent checks skipped in this environment.npm test: 902 passed, no failures.go test -racefor API, loadpoint and cmd/ftw: passed.Hardware evidence and limits
Real Audi e-tron + Easee Cloud + Pixii, 6 November 2026, CET (Europe/Stockholm). The owner reported 72% before charging, an 80% vehicle limit, and confirmed 80% after the test.
The field run used
v0.159.0-beta.1+local.3(1c385a353b91cb8596c99494843031b82811424b), which carried this correction alongside unrelated local diagnostics/pilot patches. This PR excludes those patches; the standalone upstream build has automated validation, not a separate field deployment. Charger/vehicle firmware versions were not recorded.Completed,request_active=false, measured 0 W, while the accepted order remained 10,350 W. Core correctly reportedvehicle_not_requesting/waiting/infoin 18 five-second monitor samples; no false no-power alarm.ev_resumeafter the vehicle's stop in the retained command trace; no later auto-resume in the retained Easee log.Completedalone does not prove 80%: the final level is owner-confirmed, not independently timestamped BMS telemetry. No physical fault injection or safety-limit test was performed. Detailed private diagnostic bundles remain local and are not attached publicly.Review and overlap
Draft pending human review of the rendered EV view. An AI browser preview exercised the actual before/after formatter with simulated status rows; this is not a human UI acceptance check.
#1537 and #1905 also touch feedback. This is a separate vehicle-request/completion path and adds no pilot-current or load-balancer inference; the regression fixture is independent of their
evTraceextensions. Their changes/reviews are not superseded. No automatic reviewers are requested.