Repository navigation
chore(optimizer): bundle Energyplan 0.7.0 - #1979
Merged
Merged
Conversation
Bundle the worker from srcfl/energyplan 847936a (0.7.0) for linux-arm64 and linux-amd64. The macOS worker is no longer bundled; the parent commit lets verify.py check such a bundle and skip execution on a Mac. The worker lists demand_elapsed_hours, so Core (#1966) sends it the demand hour in progress and the day's completed peak in that day's group, and the native demand test now requires the feature. The contract describes the feature and the demand-charge fields, each call's time limit since #1968, the batteries' total recovery rule and optional reply diagnostics, and it stays identical to Energyplan's copy. The worker version pins and the README follow. Licenses and forecast schemas are unchanged; the notices list two more microlp modifications. Protocol v1 is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Moves
optimizer/native/bundleto Energyplan 0.7.0 (srcfl/energyplan 847936a, tagv0.7.0-beta.1).What changes for households.
demand_elapsed_hours, so each local day counts as one sample.infeasiblereply.Bundle.
linux-arm64andlinux-amd64only. fix(native): verify a bundle that has no worker for this host #1977 letsverify.pycheck such a bundle on a Mac and skip execution there. A Mac keeps Core's own planner.microlpmodifications.Contract.
docs/energyplan-contract.mdgets the text that becomes true with this worker:demand_elapsed_hoursfeature and its negotiation;Energyplan's copy is byte-identical (sha256 d2b24ad9…).
Tests.
TestNativeEnergyplanTakesElapsedDemandHoursnow requires the feature from the bundled worker instead of skipping.Scope and safety
verify.py, the native suite with-count=5andmake verifypass on it.Verification
ftw-solver-linux-arm64sha256 a6f1609d…;ftw-solver-linux-amd64sha256 67ff308a….python3 optimizer/native/verify.py: Verified Energyplan 0.7.0, 2 platforms, linux-arm64 handshake passed.-count=5(go test ./internal/mpc ./internal/energyforecast ./cmd/ftw -run 'Native|RustForecastHost'): 360 passed, 0 failed. The 5 skips areTestNativeCapturedSiteReplay, which needs a captured request. The elapsed-demand test runs and passes.make native-solver-testandmake verify: pass.Checklist
🤖 Generated with Claude Code