Repository navigation
fix(drivers): bundle zap 3.1.2, a Zap on firmware 7.x reads as the site meter again - #1961
Merged
Merged
Conversation
…te meter again Moves the pin to srcfl/device-drivers@d662c3eb (#208). Only the Zap driver changes. A Zap on firmware 7.x serves its local API in data model v2, and zap 3.1.1 read only the old names, so FTW lost its site meter. The new tests use the payload a Zap-HAN on 7.0.3 sent, and they fail against 3.1.1. read_pv and read_battery on 7.x are not covered yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Mozart <dmozartandraws@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Zap that updates to firmware 7.x serves its local API in data model v2.
zap3.1.1 read only the old names (W,L1_V), so FTW got no power reading from the Zap and lost its site meter. An owner reported it after a Zap got the new firmware. Zaps are being updated now.Change
mainthere was at the current pin before that merge, so onlyzapchanges.nullpower stays unknown.Tested
go test ./internal/drivers/ -run Zapand./internal/fleetping/pass. The new tests fail against 3.1.1.scripts/sync-bundled-drivers.sh --checkand--behindpass.site-meter payload unavailable. This reproduces the report.phaseCurrentsAandfuse_phase.gotake the absolute value, so fuse handling is unchanged. The Home Assistant bridge publishes the value as it is, sophase_1_ais negative during export on 7.x.Not run on a full FTW site, and not tested on a Zap on older firmware. For the old names, the unit tests cover that path.
Not covered
read_pvandread_batteryon a Zap with firmware 7.x still read nothing. That follows in device-drivers and a new pin bump (srcfl/device-drivers#170).🤖 Generated with Claude Code