Skip to content

feat(notify): a choice for a device that does not follow FTW - #117

Merged
frahlg merged 1 commit into
mainfrom
notify-not-following
Nov 5, 2026
Merged

frahlg merged 1 commit into
mainfrom
notify-not-following

Conversation

@frahlg

@frahlg frahlg commented Nov 5, 2026

Copy link
Copy Markdown
Member

Problem

xorath, 5 Nov 2026: a battery charged 2.3 kW while FTW asked it to discharge 812 W. The box's page said Not following. No notification told the owner.

Change

  • control.not_following joins contract/push-catalogue.yaml:
    • Title: "A device is not following FTW"
    • Body: "{name} does not do what FTW asks. Open FTW to see why."
  • The notification settings list it as If a device does not do what FTW asks, next to the other device notices.

Pairs

This goes first. Then come srcfl/ftw (the rule, plus the copy and the regenerated push_gen.go) and srcfl/ftw-app (the copy, the phone's words and the iPhone's choices). The catalogue is byte-identical in all three.

Contract-pair: srcfl/ftw@4fc3194

Evidence

  • tests/push-contract.test.ts and Notifications.svelte.test.ts pass, 13 tests.
  • npm run test: 1188 passed on the first run. The energy chart test failed once while Core's suite loaded the laptop, then passed alone, 10 of 10.
  • npm run build is clean.
  • scripts/check-contract-drift.mjs against the Core branch says both files match byte for byte.
  • npm run check stops on three missing @cloudflare type packages on this machine. That is unrelated to this change.

🤖 Generated with Claude Code

control.not_following joins the push catalogue: the box tells the owner
when its answer to "Are we in control?" has said a device is not
following for ten minutes, as a battery that charges while FTW asks it
to discharge (xorath, 5 Nov 2026). The notification settings list it as
"If a device does not do what FTW asks".

Paired with srcfl/ftw (the rule) and srcfl/ftw-app (the phone's words);
the catalogue is byte-identical in all three.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T14:02:32.710425Z 66f0797 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ftw-webapp 66f0797 Commit Preview URL

Branch Preview URL
Nov 05 2026, 01:59 PM

@frahlg
frahlg merged commit 63fac63 into main Nov 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant