Repository navigation
fix(growatt): skip battery telemetry when no battery is connected - #203
Merged
frahlg merged 3 commits intoNov 5, 2026
Merged
Conversation
PV-only Growatt still answers the battery registers with 0, so Overview rendered a phantom Battery node. Only emit battery telemetry when voltage/SoC/power indicate a real battery. Fixes srcfl/ftw#1669. Signed-off-by: huangkongsheng <59566679+huangkongsheng@users.noreply.github.com>
miravoss26
reviewed
Nov 4, 2026
miravoss26
left a comment
miravoss26
left a comment
There was a problem hiding this comment.
Skips the battery emit in the Growatt driver when all battery readings are zero, so PV-only installs stop showing a phantom Battery node (srcfl/ftw#1669). Bumps driver and manifest to 2.1.3 and adds three harness tests.
- Gate is
bat_v > 0 or bat_soc > 0 or bat_charge_w > 0 or bat_discharge_w > 0. All four are initialised before use (growatt.lua ~L150-175), so no nil risk. - Tests cover PV-only (no emit), hybrid (emit), and a real battery at 0% SoC with voltage present (emit). That last one is the case I'd have worried about, good that it's there.
- Minor: a hybrid whose battery is fully offline (voltage 0) will now also stop emitting. That seems like the right behaviour, just flagging it.
- Security screen: no secrets, no new deps, no new network destinations.
- Note:
statusCheckRollupis empty, so I can't see CI. The new tests skip without./lua55, so worth confirming the pipeline actually ran them.
Safe to merge from my read, once CI is green.
… 2.1.3 The battery gate removes four invented numbers from growatt (20 to 16), so the ratchet needs its baseline lowered. index.yaml, devices.yaml and the support status are regenerated for the 2.1.3 manifest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
frahlg
force-pushed
the
fix/growatt-pv-only-battery-node
branch
from
November 5, 2026 14:01
5c495fe to
36eaac7
Compare
frahlg
added a commit
to srcfl/ftw
that referenced
this pull request
Nov 5, 2026
#1973) srcfl/device-drivers#203 skips the battery emit when every battery reading is 0, so a PV-only Growatt no longer draws a phantom battery beside the site's real one (#1669). The pin moves e463c653 to e07d2703; growatt is the only bundled driver that changes. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes srcfl/ftw#1669