Conversation
sraodev
force-pushed
the
feature/secure-installer
branch
from
September 8, 2026 19:54
918c34b to
5705483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New users currently have to clone and build the repository. This PR adds the reviewed installer foundation for the
ubt,ubtctl, andubtdrelease bundles created by #45.Closes #41.
Review scope
Two focused commits separate the installer/CI implementation from its checked-in review package.
The README does not advertise a curl command yet because the current public release predates the native asset contract. Release publication, a stable installer URL, mise, Homebrew, signing, Windows, daemon startup, and PATH changes remain separate gates.
Attached review documents
Reviewer roadmap
SVG · Mermaid source
Sequence diagram — selection, verification, replacement, and rollback
SVG · Mermaid source
Architecture diagram — network trust boundary, validation, and target transaction
SVG · Mermaid source
Verification
Passed locally on macOS/ARM64:
All 14 installer scenarios pass. The three Mermaid sources passed the pinned Mermaid 11.12.0 renderer, and their PNG renders were visually inspected. Workflow YAML parsed successfully.
An additional legacy Python SDK pytest attempt remains unable to collect on this host because the optional PyBluez
bluetoothmodule is absent. That suite is not part of current CI, and this PR does not change the legacy Python SDK.Important limits and remaining gates
This PR does not prove public installation because no compatible native-asset release has been published after #45. After merge, a maintainer must approve a tag, inspect the release assets, and run exact-version installs on the four native OS/architecture targets before adding the README command.
Shell rollback handles ordinary command failures and handled signals; it cannot guarantee recovery after
SIGKILL, power loss, or concurrent installers. The release binaries are not signed, notarized, attested, or accompanied by an SBOM. The canonical stable endpoint remains issue #44; mise and Homebrew remain #42 and #43.