Repository navigation
feat: images to try, floating around the middle of the empty page - #47
Merged
Merged
Conversation
Three samples float around the wordmark: an aurora and a Zhuque-2E propellant dump from Wikimedia Commons under CC BY 4.0, and a Julia set drawn for the page. Pressed, one is fetched from the page's own origin and picked as a file. The drop target is a grid, so none covers the middle, and their size follows the window. The credits go into licenses.txt. ADR-0009. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found. SummaryAdds three sample images to the empty page. Pressing one downloads the full image from the page’s own origin and opens it in the workspace.
No new actionable issues were found. Tests were inspected, not run. Reviews (2) · Last reviewed commit: "fix: one sample download at a time, ende..." · Reviewed by Greptile |
… a failed one announced Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
ADR-0001 left sample images open (section 3). ADR-0009 records what they became over three rounds today.
Three samples float around the wordmark, each leaning a little and standing straight under the pointer or the focus:
Each shows a different side of the page: a sky that bands, a picture large enough that zoom is how you see the artifacts, and a graphic that goes to lossless WebP.
sqzerresized and re-encoded the two photographs.Pressing a sample fetches it from the page's own origin and picks it as a file, so the workspace opens on it. If the fetch fails, the tile says so and can be pressed again.
The drop target is now a grid, with the middle in the centre cell and the samples in the cells around it. That way none of them covers the middle at any window size. On a wide screen they sit half-way from the corners to the middle. Their width follows the window, up to 36 to 42 rem on a 2K screen. The page fits its window down to 1280 x 680; at 1024 x 600 it runs 26 px over.
The empty page loads small AVIF copies, about 80 KB for the three, and fetches a file only when it's pressed. The repository gains 3.3 MB.
The CC BY photographs need credit.
public/samples/CREDITS.txtgives the author, the licence, the source and what was changed, and the build appends it tolicenses.txt, which the footer links. I left Schenna at dusk out because it's CC BY-SA, and the share-alike would apply to our resized copy too.samples.test.tsxfetches each file and checks it against the size its tile states, so a sample swapped without updating its size fails. The end-to-end suite presses the Julia set on the built page, with the policy on, and getsjulia.webp, lossless.Browsers tried
Headless Chromium and Firefox through Playwright against the built page, light and dark, at 2560 x 1440, 1440 x 900, 1280 x 680, 1024 x 600 and 390 x 844. Not Safari.
New dependencies
None. The images are CC BY 4.0 and our own, as above.
Checklist
pnpm checkpasses locally, or CI shows it greendocs/adr/README.mdand its entry in.greptile/files.json, if there is oneContent-Security-Policyis unchanged, or the PR says why it had to change🤖 Generated with Claude Code