Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"command": "analyze",
"args": ["--dialect", "duckdb", "--schema", "schema.sql", "query.sql"],
"contexts": ["base"]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- name: Page :many
SELECT id FROM readings ORDER BY id LIMIT 50% OFFSET $1;
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CREATE TABLE readings (id INTEGER NOT NULL);
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
[
{
"name": "Page",
"cmd": ":many",
"columns": [
{
"name": "id",
"type": {
"name": "integer"
},
"table": "readings"
}
],
"params": [
{
"number": 1,
"column": {
"name": "",
"type": {
"name": "integer"
}
}
}
]
}
]
7 changes: 2 additions & 5 deletions internal/engine/duckdb/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,8 @@ func (c *cc) applyModifiers(stmt *ast.SelectStmt, mods []dw.ResultModifier) {
case *dw.OrderModifier:
stmt.SortClause = c.convertOrderBys(m.Orders)
case *dw.LimitModifier:
// LIMIT n% has no row-count equivalent.
if m.LimitType == dw.LimitPercentage {
continue
}
if m.Limit != nil {
// LIMIT n% has no row-count equivalent, but its OFFSET counts rows.
if m.Limit != nil && m.LimitType != dw.LimitPercentage {
stmt.LimitCount = c.convertExpr(m.Limit)
}
if m.Offset != nil {
Expand Down
Loading