Repository navigation
duckdb: report unsupported star modifiers during query analysis - #4700
Open
1akashkalita wants to merge 1 commit into
Open
1akashkalita wants to merge 1 commit into
1akashkalita wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4660.
With
SELECT * EXCLUDE (secret) FROM people, DuckDB can return several columns. On current main,sqlc analyzereports one untyped column named?column?. The same happens for* REPLACE, and Go generation eventually fails on the question mark in the generated source.This takes the issue's suggested error-at-generation approach. The DuckDB converter identifies star expressions whose output shape sqlc cannot yet determine. Analysis then reports the unsupported expression at the query, before code generation. Plain and qualified stars continue through the existing expansion path.
The CLI regression covers both
EXCLUDEandREPLACE. I reproduced the incorrect JSON on main and checked the diagnostics with bothsqlc analyzeandsqlc generate. These passed locally with Go 1.26.5 andCGO_ENABLED=0:go test ./internal/core/... ./internal/engine/duckdb/... ./internal/compiler/... ./internal/sql/...go test ./internal/endtoend -run '^TestReplay$/^base$'