Introduce immediate attribute on @CacheEvict#36858
Open
guhyunwoo wants to merge 1 commit into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
By default, @CacheEvict delegates to Cache#clear / Cache#evict, which the Cache contract allows to be performed asynchronously or in a deferred fashion. With a Redis-backed cache, for example, Cache#clear may translate to an asynchronous UNLINK that can later remove an entry written by a concurrent @cACHEpUT. The new immediate attribute delegates to Cache#invalidate / Cache#evictIfPresent instead, expecting all affected entries to be invisible for subsequent lookups as soon as the operation returns. beforeInvocation=true continues to imply immediate eviction. This also aligns the call site with the existing immediate parameter on AbstractCacheInvoker#doEvict / #doClear, which CacheAspectSupport had been driving from isBeforeInvocation(), conflating scheduling with visibility. Closes spring-projectsgh-36806 Signed-off-by: Hyunwoo Gu <realization0327@gmail.com>
guhyunwoo
force-pushed
the
gh-36806-immediate-cache-evict
branch
from
e4be6b3 to
5867512
Compare
sbrannen
added
the
in: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36806.
By default,
@CacheEvictdelegates toCache#clear/Cache#evict, which theCachecontract allows to be performed in an asynchronous or deferred fashion. With a Redis-backed cache, for example,Cache#clearmay translate to an asynchronousUNLINKthat can later remove an entry written by a concurrent@CachePut.This PR introduces a new
immediateattribute on@CacheEvictthat delegates toCache#invalidate/Cache#evictIfPresentinstead, expecting all affected entries to be invisible for subsequent lookups as soon as the operation returns.beforeInvocation=truecontinues to imply immediate eviction for backwards compatibility, since the original contract has always usedCache#invalidatein that case.It also aligns the call site with the existing
immediateparameter onAbstractCacheInvoker#doEvict/#doClear, whichCacheAspectSupporthad been driving fromisBeforeInvocation(), conflating scheduling with visibility.