Auto-grow nested map values for property writes#36857
Open
yeomin4242 wants to merge 1 commit into
Open
Conversation
Prior to this commit, getPropertyHoldingValue() could auto-grow a null map value only for a single map level. For a property path such as nestedNestedMap[A][B][C], resolving the value that should hold the final key returned null before processKeyedProperty() could write the final map entry. This commit shares indexed traversal between regular property reads and the holder lookup used by property writes, enabling map value auto-growth only for the holder lookup. Regular getPropertyValue() traversal keeps its existing behavior. Closes spring-projectsgh-32154 Signed-off-by: YeongJae Min <whereismysejong@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-32154
getPropertyHoldingValue()already has a dedicated auto-grow path formap values, but that path only handles a single map level.
For a property path such as
nestedNestedMap[A][B][C], resolving thevalue that should hold the final key returned
nullbeforeprocessKeyedProperty()could write the final map entry.This PR shares indexed traversal between regular property reads and the
holder lookup used by property writes, enabling missing intermediate map
values to be auto-grown in a single pass.
The change is intentionally scoped to property writes. Regular
getPropertyValue(...)traversal keeps its existing behavior.