Refactor SET command API to include CAS options#3324
Closed
Dgramada wants to merge 2 commits into
Closed
Conversation
…for the DELEX command. Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
…enable annotation for IFEQ and IFNE tests in DefaultValueOperationsIntegrationTests. Signed-off-by: Yordan Tsintsov <yordan.tsintsov@redis.com>
spring-projects-issues
added
the
status: waiting-for-triage
Dgramada
changed the title
mp911de
added
type: enhancement
Member
|
I should have been more precise about deprecations. It has been only targeting methods accepting |
mp911de
added a commit
that referenced
this pull request
Mar 12, 2026
Use SetCondition instead of SetOption, remove implementations using SetOption and tests. Reduce tests to avoid cartesian products caused by matrix testing on all sorts of levels, instead, test conversions to driver-specific argument objects and ensure that argument objects are applied. Revert deprecations of setIf… methods accepting Duration/Expiration. See #3324
Member
|
Thank you for your contribution. That's merged and polished now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors SET command API to include the new CAS options provided by Redis 8.4. This PR follows the pattern used for the DELEX command implementation and is a replacement for #3304. It reduces the method overloads and provides a builder that can be used for various SET command arguments.