Allow OllamaApiAutoConfiguration conditional instantiation based on chat model and embedding model properties#5077
Open
nicolaskrier wants to merge 1 commit into
Conversation
Contributor
Author
|
In 1.1.0-M2 version,
These two former auto-configurations have conditions on different properties to disable them. I have reintroduced these conditions on |
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
2 times, most recently
from
81eeb82 to
577a507
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
from
577a507 to
3a606e6
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
7 times, most recently
from
e2f7455 to
0be6fc1
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
from
0be6fc1 to
05763ad
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
2 times, most recently
from
eabf94b to
6469547
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
3 times, most recently
from
5546d2c to
a263c70
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
from
a263c70 to
3fccc1d
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
from
3fccc1d to
b95b06b
Compare
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
from
b95b06b to
8ebe4ee
Compare
…hat model and embedding model properties - Introduce OllamaChatOrEmbeddingCondition for this logic - Add unit tests covering the different scenarios - Refactor existing unit tests Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com>
nicolaskrier
force-pushed
the
ollama-api-conditional-instantiation
branch
from
8ebe4ee to
8d847dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.