Adding Vertex AI Imagen models support#2144
Conversation
735bd7d to
965e590
Compare
|
@ddobrin can you please take a look? |
|
Any update here? I am also interested in this feature. |
|
I am currently using this feature as a custom-made version. I hope it gets updated soon. If help is needed, I would be willing to participate. |
|
@byungjunn Thanks! Any help reviewing the PR is much appreciated. |
|
@Marzouki-Sami |
Closes spring-projectsgh-2133 Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
…gen/pom.xml Updating the version. Co-authored-by: ByungJun <kbj7227@naver.com> Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
…gen/pom.xml changing artifactId Co-authored-by: ByungJun <kbj7227@naver.com> Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
…gen/pom.xml removing unnecessary spaces Co-authored-by: ByungJun <kbj7227@naver.com> Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
Co-authored-by: ByungJun <kbj7227@naver.com> Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
|
@byungjunn @ilayaperumalg @markpollack i had some issues with resolving the conflict and to resolve the conflict i had to remove the commits, doing that closed this PR is it possible to reopen it, if not i will create a new PR and link it to this one. |
7fef979 to
54f3ba7
Compare
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
|
@byungjunn thanks for the review the mentioned points above are fixed. Can you check them? |
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
|
Any updates? |
switching constructor params to match only call in VertexAiImagenImageModel.java Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
|
Just a minor change added in the last commit (f341567). Switching the constructor params ( mimetype and model) of |
… missing imageOptions Author: Marzouki-Sami <samymarzouki502@gmail.com> Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
|
@byungjunn can you review pls. |
|
@markpollack @ilayaperumalg @ddobrin @byungjunn Any updates? If not, will it take much longer? |
|
@markpollack @ilayaperumalg @ddobrin How much time does it take to get a response on the previous comment? |
|
@byungjunn It has been over four months since I requested a review. Are you still available for review, or should this be passed to another person to review it? |
@Marzouki-Sami Long time no see. I’ve been busy with a lot of things, so we haven’t caught up in a while. I’ve reviewed it enough, and I think it might be better now for the people who actually have the authority to merge to take a look. |
|
@markpollack @ilayaperumalg @ddobrin What’s next? The latest changes have been reviewed and approved by @byungjunn. If another reviewer is needed, please assign one. |
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
|
@markpollack @ilayaperumalg @ddobrin This pull request has been open for over a year without a response to previous mentions. I understand the team may be busy, so if you don't have the capacity to review this at the moment, could you please delegate the review to another team member with write access? |
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
|
@markpollack @ilayaperumalg @ddobrin Another conflict occurred, and there has still been no response to any of the previous comments. |
|
I created another clean PR, in order to solve the issue : #2133 |
|
Hi @OreOreDa I would recommend migrating to the Gemini 3.x pro image models beforehand, while using the Google GenAI SDK. Thank you |
|
@ddobrin @ilayaperumalg @sdeleuze My new PR for Google GenAI image models |
Closes gh-2133
Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits