Fix ordering in test - #4255
Merged
ryanjbaxter merged 1 commit intoAug 4, 2026
Merged
Conversation
Caused by a change in Spring Framework spring-projects/spring-framework@b00f691
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by a change in Spring Framework spring-projects/spring-framework@b00f691
Previously Collectors.toSet() returned a HashSet, so the iteration order depended on 'String.hashCode()' for the keys in this test that happened to be 'quux, foo[], baz'. 'rewriteRequestParameter' removes and re-adds the rewritten parameter, moving foo[] to the end and yielding 'quux, baz, foo[]', which is what the assertion had hardcoded.
With 'LinkedHashSet', the order now follows 'getParameterMap()', which 'MockHttpServletRequest' backs with a 'LinkedHashMap' i.e. insertion order 'foo[], baz, quux', becoming 'baz, quux, foo[]' after the rewrite.