Avoid draining failed streaming proxy responses#4217
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
Fixes spring-cloudgh-3999 Signed-off-by: goutamadwant <workwithgoutam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-3999
This PR updates MVC proxy response cleanup so streaming response copy failures close the active response body stream directly instead of calling
ClientHttpResponse.close(). SomeClientHttpResponseimplementations drain remaining content duringclose(), which can hang for long-lived SSE responses after the downstream client disconnects.Normal completion and non-streaming error cleanup still use
ClientHttpResponse.close().Tests:
./mvnw -pl spring-cloud-gateway-server-webmvc -Dtest=RestClientProxyExchangeTests test./mvnw -pl spring-cloud-gateway-server-webmvc -Dtest=RestClientProxyExchangeTests,AbstractProxyExchangeTests,ProxyExchangeHandlerFunctionTest test