Repository navigation
docs: add security policy and list runtime dependencies in NOTICE - #4
Conversation
Samy-O7
left a comment
Samy-O7
left a comment
There was a problem hiding this comment.
Reviewed while in draft. SECURITY.md matches our security policy template. One gap in the dependency list: faraday-net_http 3.4.4 allows net-http ~> 0.5, which now resolves to net-http 0.10.0. That release depends on net-protocol >= 0.3.0, which depends on timeout. Both are Ruby / BSD-2-Clause.
- NOTICE: suggestion inline.
- THIRD-PARTY-LICENSES: needs entries for both gems. Their repos carry the same BSDL and COPYING texts as the existing net-http section.
Good from my side after that.
|
|
||
| - faraday (MIT) | ||
| - faraday-net_http (MIT) | ||
| - net-http (Ruby / BSD-2-Clause) |
There was a problem hiding this comment.
| - net-http (Ruby / BSD-2-Clause) | |
| - net-http (Ruby / BSD-2-Clause) | |
| - net-protocol (Ruby / BSD-2-Clause) | |
| - timeout (Ruby / BSD-2-Clause) |
There was a problem hiding this comment.
Added both to NOTICE in 14d1870, along with their license texts in THIRD-PARTY-LICENSES.
Samy-O7
left a comment
Samy-O7
left a comment
There was a problem hiding this comment.
The new commit adds net-protocol and timeout to NOTICE and THIRD-PARTY-LICENSES. Their BSDL and COPYING texts match upstream at net-protocol v0.4.0 and timeout v0.6.1, and CI is green.
Changes