refactor: Create LocaleAffinityBiCalculatorBaseImpl#25
Merged
ericfjosne merged 1 commit intomainfrom Jun 23, 2025
Merged
Conversation
ericfjosne
force-pushed
the
refactor-Create-LocaleAffinityBiCalculatorBaseImpl
branch
2 times, most recently
from
00fab55 to
35c17bb
Compare
ericfjosne
force-pushed
the
refactor-Create-LocaleAffinityBiCalculatorBaseImpl
branch
from
35c17bb to
383bc45
Compare
shobhitt-spotify
approved these changes
Jun 23, 2025
ericfjosne
deleted the
refactor-Create-LocaleAffinityBiCalculatorBaseImpl
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of making use of the related reference locales logic to perform an affinity bi-calculation, let's implement the interface in a stand alone class, and consolidate methods usage between the
LocaleAffinityCalculatorand theLocaleAffinityBiCalculator.