Merged
Conversation
…ub.com/spotify/java-locales into feat-Add-locale-affinity-bi-calculator
ericfjosne
force-pushed
the
feat-Add-locale-affinity-bi-calculator
branch
from
d57310c to
9e137f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, locale join operations based on locale affinity require to understand and implement reference locale-based operations.
This is not ideal and can be abstracted away fully by offering a
LocaleAffinityBiCalculatorinterface, which exposes the following method:We will still make use of the related reference locale-based helpers under the hood to perform the actual calculation, but at least users of the library won't ever have to deal with it, and are offered a simpler interface to achieve the same result.
This PR also includes a bug fix for an issue that was detected during tests, relating to locale affinity calculation involving Bosnian and Croatian.