fix: validate and raise ValueError for negative n in get_nns methods - #701
Open
saitejabandaru-in wants to merge 1 commit into
Open
fix: validate and raise ValueError for negative n in get_nns methods#701saitejabandaru-in wants to merge 1 commit into
saitejabandaru-in wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #700. When passing a negative number for n (number of neighbors) to get_nns_by_item or get_nns_by_vector, the signed int32_t parses correctly but is cast to unsigned size_t inside get_nns_by_item in the C++ library. This causes it to become SIZE_MAX, leading to integer overflows in search_k and returning meaningless values or empty lists. This adds a clean check in the Python C-extension wrapper to raise a ValueError.