Open
Conversation
kmcbride
force-pushed
the
deprecate-effect-handler-protocol
branch
6 times, most recently
from
fd8cb51 to
6dfa6ac
Compare
erikprice
approved these changes
Apr 24, 2024
erikprice
left a comment
erikprice
left a comment
There was a problem hiding this comment.
Some great refactoring in this PR. I think I agree with the deprecation as well.
| // When an effect has completed, it should be removed from this dictionary. | ||
| // When disposing this effect handler, all entries must be removed. | ||
| private var handlingEffects: [Int64: EffectHandlingState<Event>] = [:] | ||
| private var ongoingEffects: [Int64: EffectHandlingState<Event>] = [:] |
kmcbride
force-pushed
the
deprecate-effect-handler-protocol
branch
from
6dfa6ac to
d5c2d36
Compare
kmcbride
force-pushed
the
deprecate-effect-handler-protocol
branch
from
d5c2d36 to
1892541
Compare
kmcbride
force-pushed
the
deprecate-effect-handler-protocol
branch
from
1892541 to
9ad1897
Compare
kmcbride
force-pushed
the
deprecate-effect-handler-protocol
branch
from
9ad1897 to
e94c6bb
Compare
kmcbride
force-pushed
the
deprecate-effect-handler-protocol
branch
from
e94c6bb to
879ff08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose deprecating
EffectHandlerand removing it in a future release because I believe it leads to frequent misuse of the API without providing any obvious advantages. This removal will ideally encourage users to be more intentional about which type of handler they route to.