Conversation
Generate an S256 verifier/challenge pair at login, pass the challenge to /auth/device/login, and redeem the one-time code with the verifier at token exchange. The backend now requires this on every device login.
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as a duplicate. This was opened by a background agent that did not see the already-open PR. The canonical PR with the same change (and more) is #1. Reopen if needed. |
Adds PKCE to
spoo login, which the backend now requires on every device authorization.What changed
internal/auth/pkce.go). The verifier is a 43-char base64url string (32 random bytes), the minimum RFC 7636 length.GET /auth/device/loginnow carriescode_challengeandcode_challenge_method=S256alongside the existingapp_id,redirect_uri, andstate.DeviceFlow.Runreturns the one-time code together with the verifier;ExchangeDeviceCodesendscode_verifierin thePOST /auth/device/tokenbody.Compatibility
Older CLI builds fail at the new login step with the backend's "update the app" error page. Nothing else in the flow changes: the loopback callback, state check, and stored token shape are untouched, and existing sessions keep working.
Testing
go build ./...,go vet ./..., andgo test ./...all pass. New tests cover the PKCE derivation (including the RFC 7636 Appendix B fixed vector), that the login URL carries a 43-char S256 challenge, that the returned verifier hashes to it, and that the exchange body includescode_verifier.Pairs with the backend change (spoo-me/spoo#260).