Conversation
Collaborator
|
Oh, well spotted. Should we add a |
johmedr
added a commit
to MPython-Package-Factory/mpython-core
that referenced
this pull request
Mar 24, 2025
This should have been solve by [this PR](spm/spm-python#35).
johmedr
added a commit
that referenced
this pull request
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A somewhat recent change to the type system (from about ~2 weeks ago) had quite profoundly broken the conversion of objects from matlab to python. The fix is very short and simple (830af61).
It's a bit annoying that this was not detected by our unit tests. I haven't thought too much about which tests should be added to cover this issue yet. The issue is that since the aforementioned change, dictionaries and lists are not treated exactly the same way depending on whether we know that we are converting mpython objects or not.
I've also made tiny stylistic changes to make my linter happy.