You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
syntheticsclientv2 did not expose client methods or models for SSL certificate tests.
CA certificate /cacerts create/read/update/delete/list support was missing, so downstream consumers could not manage custom CA trust material through the v2 client.
After the change?
Added SSL test CRUD methods for /tests/ssl.
Added CA certificate create/get/list/update/delete methods for /cacerts.
Added request/response models for SSL tests and CA certificates.
Added unit test coverage for SSL and CA certificate envelopes, request bodies, blank update responses, and delete status handling.
Kept /certificates mTLS/client certificate support out of scope.
Pull request checklist
Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)
Acceptance Test Output
Not run. This is a syntheticsclient-only change with no live tenant acceptance flow.
Validation run:
GOCACHE=/private/tmp/codex-go-cache GOMODCACHE=/private/tmp/codex-go-mod-cache make test
0 issues.
PASS
coverage: 71.5% of statements
ok github.com/splunk/syntheticsclient/v2/syntheticsclientv2
CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request
[H1] syntheticsclientv2/common_models.go: CaCertificateV2Response expects a {"cacert": ...} envelope for single CA cert create/get, but the app client models GET /cacerts/{id} as returning the CA certificate object directly. If the API returns the bare object, json.Unmarshal succeeds and leaves resp.CaCert zero-valued, so callers get an apparently successful but empty result. The single-object CA response should unmarshal into CaCertificate directly; keep the list response wrapped as {"cacerts": [...]}.
[H2] syntheticsclientv2/common_models.go: SslCheckV2Input.Test.ServerName is a string, so the client cannot send serverName: null. The Synthetics app treats serverName as nullable and explicitly sends null when blank. This client will send "" for the default/no-SNI case, which can be rejected or persisted differently. Use *string for request/response ServerName.
[M1] syntheticsclientv2/common_models.go: the SSL response/input models omit mfaCertificateId, even though the app’s SSL model includes it on both read and update config. Even if certificate CRUD is out of scope, updating an SSL test should be able to preserve an existing mTLS/client cert reference; otherwise callers can drop it accidentally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SYN-5569
Before the change?
syntheticsclientv2did not expose client methods or models for SSL certificate tests./cacertscreate/read/update/delete/list support was missing, so downstream consumers could not manage custom CA trust material through the v2 client.After the change?
/tests/ssl./cacerts./certificatesmTLS/client certificate support out of scope.Pull request checklist
make testacc), and pasted in this PR (for bug fixes / features)Acceptance Test Output
Does this introduce a breaking change?