Skip to content
This repository was archived by the owner on Dec 16, 2021. It is now read-only.

Code Salon Emoji

Jump to bottom
Neil Williams edited this page Nov 4, 2019 · 5 revisions

⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️

Please use GitHub's native review UI whenever possible. It's much easier to understand and works with non-Harold tools (like GitHub itself).

⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️

Harold implements the entirely made up Code Salon Review Method™. This consists of a few emoji that are used to indicate states of the review process. Those emoji are, in roughly the order they'd be seen in review:

  • 💅 (:nail_care:)

    by a reviewer: "I've finished my review pass and am awaiting your responses."

  • 💇 (:haircut:)

    by the author: "I've responded or made appropriate changes and am ready for further review."

    (this doesn't accept usernames like 👓, it just pings everyone who has reviewed so far. use the GitHub UI if you want to be more granular)

  • 🐟 (:fish:)

    by a reviewer: "I think this pull request is ready for merging."

  • 👓 (:eyeglasses:)

    followed by a list of @github-username mentions: "[mentioned users] please review this pull request"

    (this is for initial review requests, not pinging people to come back like 💇‍♂️)

  • 🏃 (:running:)

    by a reviewer: "I don't have time to review this at the moment, please find someone else."

  • 🔕 (:no_bell:)

    by a reviewer: "This is just a comment and requires no action."

Clone this wiki locally