Skip to content

Keep every benchmark under bench/ - #67

Merged
XiangpengHao merged 1 commit into
mainfrom
merge-bench-dirs
Nov 18, 2026
Merged

XiangpengHao merged 1 commit into
mainfrom
merge-bench-dirs

Conversation

@XiangpengHao

Copy link
Copy Markdown
Collaborator

benches/ held one file, shared_reads.rs, the t4 crate's divan micro-benchmark, right beside bench/, the t4-bench crate. Two benchmark folders at the top level was confusing.

  • benches/shared_reads.rs → bench/benches/shared_reads.rs, a [[bench]] of t4-bench. It uses only t4's public API, so no code changed.
  • divan moves from t4's dev-dependencies to t4-bench's, with pollster and tempfile, which the benchmark also uses (t4's own tests still use those two).
  • Doc references in doc/04-multi-device.md and doc/11-shared-mode.md follow the move.
  • flake.nix: the dev shell's comment named a benches/read_throughput.rs that no longer exists; it now says what fio and Python are there for.

Tradeoff: CI checks only the root crate, so this benchmark is no longer compiled or linted in CI. Building it now builds t4-bench's DataFusion and Vortex too.

Run it with cargo bench -p t4-bench --bench shared_reads.

Checked locally (macOS): cargo fmt --check, cargo clippy --all-targets -- -D warnings, cargo clippy -p t4-bench --bench shared_reads -- -D warnings, and a short run of the benchmark (3 samples, all six cases ran). cargo test not run; only a dev-dependency left the root crate.

benches/ held one file, the t4 crate's shared_reads micro-benchmark,
beside bench/, the benchmark crate. It moves into bench/ as a benchmark
of t4-bench; it uses only t4's public API. The flake's comment named a
benches/read_throughput.rs that no longer exists.
@XiangpengHao
XiangpengHao enabled auto-merge (squash) November 18, 2026 18:55
@XiangpengHao
XiangpengHao merged commit 420b7ff into main Nov 18, 2026
8 checks passed
@XiangpengHao
XiangpengHao deleted the merge-bench-dirs branch November 18, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant