Repository navigation
Keep every benchmark under bench/ - #67
Merged
Merged
Conversation
benches/ held one file, the t4 crate's shared_reads micro-benchmark, beside bench/, the benchmark crate. It moves into bench/ as a benchmark of t4-bench; it uses only t4's public API. The flake's comment named a benches/read_throughput.rs that no longer exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benches/held one file,shared_reads.rs, the t4 crate's divan micro-benchmark, right besidebench/, thet4-benchcrate. Two benchmark folders at the top level was confusing.benches/shared_reads.rs→bench/benches/shared_reads.rs, a[[bench]]oft4-bench. It uses only t4's public API, so no code changed.divanmoves from t4's dev-dependencies tot4-bench's, withpollsterandtempfile, which the benchmark also uses (t4's own tests still use those two).doc/04-multi-device.mdanddoc/11-shared-mode.mdfollow the move.flake.nix: the dev shell's comment named abenches/read_throughput.rsthat no longer exists; it now says what fio and Python are there for.Tradeoff: CI checks only the root crate, so this benchmark is no longer compiled or linted in CI. Building it now builds
t4-bench's DataFusion and Vortex too.Run it with
cargo bench -p t4-bench --bench shared_reads.Checked locally (macOS):
cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo clippy -p t4-bench --bench shared_reads -- -D warnings, and a short run of the benchmark (3 samples, all six cases ran).cargo testnot run; only a dev-dependency left the root crate.