Repository navigation
Run native-reader CMake package checks in a parallel CI job - #31
Merged
Merged
Conversation
native-readers was the critical path of CI (12-18 min). Its runner did
everything serially, including the installed-CMake-package checks
(Vortex on and off), which take ~5 min and build their own release
library from a separate cargo target dir, using none of the earlier
artifacts.
Add `--only {all,core,cmake}` to scripts/test_native_readers.py (the
default, all, keeps the local behaviour) and run the CMake checks in a
new native-readers-cmake job alongside native-readers, which keeps its
name and runs everything else.
Signed-off-by: Joseph Isaacs <joe.isaacs@live.co.uk>
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #30, with the commit authored and signed off by Joseph Isaacs so the CLA check can pass.
Summary
native-readersis the CI critical path: the last run (40681760283) took 12m38s wall-clock, andnative-readerstook 12m36s, while the next-slowest job,java-sidecars, took 4m07s. On develop (38336558042) it was 17m56s.scripts/test_native_readers.pygains--only {all,core,cmake}. The default,all, still runs everything, so local use doesn't change.native-readerskeeps its name and runs--only core. A newnative-readers-cmakejob runs--only cmakein parallel with it.Type of change
SKILLS.md→ Adding a new dataset)SKILLS.md→ Adding a new transform handler)Notes for the reviewer
if core:/if cmake:.git diff -wshows the real change.native-readerscheck name is unchanged.Generated by Claude Code