Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/dco.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
allowRemediationCommits:
# Allow individual remediation commits
# https://github.com/dcoapp/app#individual-remediation-commit-support
individual: true
# Allow third-party remediation commits
# https://github.com/dcoapp/app#third-party-remediation-support
thirdParty: false

require:
# Members are required to sign-off commits
# https://github.com/dcoapp/app#skipping-sign-off-for-organization-members
members: true
2 changes: 2 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- Sign off each commit with git commit -s; see CONTRIBUTING.md#developer-certificate-of-origin-dco. -->

## Summary
<!-- What changed and why. 1–3 bullets is plenty. -->

Expand Down
33 changes: 33 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ the extras from the previous one (e.g. syncing `--extra dev` after

## Before you open a PR

Sign off your commits as described under [Developer Certificate of Origin](#developer-certificate-of-origin-dco).

Three checks are the minimum gate (CI runs all three):

```bash
Expand Down Expand Up @@ -122,3 +124,34 @@ For security-related issues, do **not** open a public issue — see
By submitting a PR, you agree that your contribution will be licensed under
the [Apache License 2.0](LICENSE), the same license that covers the rest of
the project.

## Developer Certificate of Origin (DCO)

Raincloud uses the [Developer Certificate of Origin 1.1](https://developercertificate.org/)
for contributions. Signing off a commit certifies that you have the right to
submit the contribution under the project's license and agree to the DCO's terms.
No separate Contributor License Agreement (CLA) is required.

Sign off every commit, including contributions from maintainers and organization
members. With your name and email configured in Git, use:

```bash
git commit -s -m "Describe the change"
```

This adds a trailer matching the commit author's name and email:

```text
Signed-off-by: Your Real Name <your.real.email@example.com>
```

Use your real name and email address, as in
[Vortex's contribution policy](https://github.com/vortex-data/vortex/blob/develop/CONTRIBUTING.md#developer-certificate-of-origin-dco).
A DCO sign-off is distinct from a cryptographic commit signature (`git commit -S`).

If you missed the sign-off on your latest commit, add it with
`git commit --amend --no-edit -s`. For earlier commits, you can add an
[individual remediation commit](https://github.com/dcoapp/app#individual-remediation-commit-support)
instead of rewriting history. Only the original author can remediate their
commits; third-party remediation is disabled. The DCO app configuration is in
[`.github/dco.yml`](.github/dco.yml).
2 changes: 1 addition & 1 deletion clients/c/tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ if(ARROW_INCLUDE AND ARROW_LIBRARY)
IMPORTED_LOCATION "${ARROW_LIBRARY}"
INTERFACE_INCLUDE_DIRECTORIES "${ARROW_INCLUDE}")
add_executable(read-cpp read.cpp)
target_compile_features(read-cpp PRIVATE cxx_std_17)
target_compile_features(read-cpp PRIVATE cxx_std_20)
target_link_libraries(read-cpp PRIVATE raincloud::reader consumer_arrow)
endif()
2 changes: 1 addition & 1 deletion scripts/test_native_readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def run(args, **kwargs):
arrow_dir = Path(pa.get_library_dirs()[0])
arrow_lib = sorted(arrow_dir.glob("libarrow.so*"), key=lambda p: len(p.name))[0]
run(["cc", "-std=c11", "-Wall", "-Wextra", "-Werror", "clients/c/tests/read.c", f"-I{include}", f"-L{lib}", "-lraincloud_reader", f"-Wl,-rpath,{lib}", "-o", temp / "read-c"])
run(["c++", "-std=c++17", "-Wall", "-Wextra", "-Werror", "clients/c/tests/read.cpp", f"-I{include}", "-isystem", pa.get_include(), f"-L{lib}", "-lraincloud_reader", f"-Wl,-rpath,{lib}", arrow_lib, f"-Wl,-rpath,{arrow_dir}", "-o", temp / "read-cpp"])
run(["c++", "-std=c++20", "-Wall", "-Wextra", "-Werror", "clients/c/tests/read.cpp", f"-I{include}", "-isystem", pa.get_include(), f"-L{lib}", "-lraincloud_reader", f"-Wl,-rpath,{lib}", arrow_lib, f"-Wl,-rpath,{arrow_dir}", "-o", temp / "read-cpp"])
for exe in ("read-c", "read-cpp"):
run([temp / exe, temp / "options.json", missing], env={**env, "PATH": "/nonexistent"})

Expand Down
Loading