util: parseSizeInBytes returns 0 for single-byte strings like 1B#2132
Open
c-tonneslan wants to merge 1 commit into
Open
util: parseSizeInBytes returns 0 for single-byte strings like 1B#2132c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
…ount parseSizeInBytes only stripped the trailing 'b'/'B' inside the "lastChar > 1" branch, so "1B" or "1b" fell through to cast.ToInt with the unit still attached and returned 0. Hoisted the strip out of that branch so single-digit byte sizes parse like the rest. Test cases for "1b" and "1B" added; the existing cases still pass. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`parseSizeInBytes` only stripped the trailing `b`/`B` inside the `lastChar > 1` branch, so `1B` and `1b` fell through with the unit still attached and `cast.ToInt("1B")` returned 0.
```
parseSizeInBytes("1B") // current: 0, expected: 1
parseSizeInBytes("12 b") // current: 12, still 12 with the fix
parseSizeInBytes("43 MB") // current: 45088768, unchanged
```
Hoisted the strip so it runs whether or not a k/m/g prefix is in front. Added `1b` and `1B` cases to `TestSizeInBytes`; the existing cases still pass.