lnworker: split LNWallet and LNWorker: LNWallet "has an" LNWorker #10372
+836
−765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
force-pushed
the
202512_lnworker_split
branch
7 times, most recently
from
98866b7 to
d13ac4e
Compare
Member
Author
|
This is ready for review. There is potential for follow-ups ofc, but I think it is in a good state we could merge for incremental progress. |
SomberNight
force-pushed
the
202512_lnworker_split
branch
from
2ee0c55 to
e0284e8
Compare
Member
Author
Member
|
I would prefer to merge this asap, because of possible conflicts |
f321x
reviewed
Jan 5, 2026
f321x
reviewed
Jan 5, 2026
Member
f321x
left a comment
f321x
left a comment
There was a problem hiding this comment.
Running this for ~1-2 weeks now on android, had no issues. looks good to me.
- LNWallet no longer "is-an" LNWorker, instead LNWallet "has-an" LNWorker - the motivation is to make the unit tests nicer, and allow writing unit tests for more things - I hope this makes it possible to e.g. test lnsweep in the unit tests - some stuff we would previously have to write a regtest for, maybe we can write a unit test for, now - in unit tests, MockLNWallet now - inherits LNWallet - the Wallet is no longer being mocked
no functional changes
These better hold, lol: wallet.lnworker.wallet == wallet lnworker.wallet.lnworker == lnworker
SomberNight
force-pushed
the
202512_lnworker_split
branch
from
e0284e8 to
9277241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major simplification re how we are mocking things in
test_lnpeer.pyand friends.not done:
{wallet,chan}.lnworkerto*.lnwalletpeer.lnworkeris polymorphic betweenLNWalletandLNGossipLNPeerManager._lnwallet_or_lngossiphas the same polymorphismlnworker.py(LNWallet is 3000 lines out of 4000 of that file) but that would be really annoying for some branches/PRs