fix(core): skill hash mismatch causes false update detection - #3
Merged
Merged
Conversation
The applier was using computeHash(params) for skill resources while the planner uses computeSkillHash(display_title, files). This mismatch caused skills to always appear as changed on subsequent plans because the stored hash never matched the planner's computed hash. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeHash(params)for skill resources, while the planner usescomputeSkillHash(display_title, files). This caused two issues:SkillUpdateParamshas onlyfiles(nodisplay_title), so the stored hash always differed from the planner's hashcomputeHashdoesn't sort files by path or normalize to{path, content}likecomputeSkillHashdoescomputeSkillHash, ensuring the stored hash matches the planner's computationcomputeSkillHashTest plan
plantwice against an existing deployment to confirm no spurious diffs🤖 Generated with Claude Code