Publishing Gateway images to ghcr#315
Open
lucaspar wants to merge 3 commits into
Open
Conversation
lucaspar
added
ci/cd
|
Review changes with Changed Files
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6e9dac4. Configure here.
The gwy-build-and-push job's 'if' condition omitted the branch guard for workflow_dispatch events. Due to &&-over-|| precedence, any workflow_dispatch from any branch could push dev-<sha> images to ghcr.io. Wrap both push and workflow_dispatch clauses with the master/main branch check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Production deploys now depend on ghcr image availability and tag discipline (
stable/SDS_GATEWAY_TAG); mis-promotion or failed pushes could block or skew rollouts, though runtime code paths are unchanged.Overview
Adds CI publishing for the Gateway Django image to
ghcr.io/spectrumx/sds-gatewayafter pre-commit and Django tests pass on pushes tomain/master(or manual dispatch). Images getdev-<short-sha>tags plusdevon the default branch; build uses the production Dockerfile with GHA cache andGIT_COMMIT/BUILD_ENVIRONMENT=productionbuild args.Introduces a manual
gateway-promote-stableworkflow that retags an existingdev-<sha>image tostableviadocker buildx imagetools create(no rebuild).Production compose stops local
buildfor the app and all Celery services; they now pullghcr.io/spectrumx/sds-gateway:${SDS_GATEWAY_TAG:-stable}instead ofsds-gateway-prod-app.Across Gateway and SDK workflows, GitHub Actions are bumped (e.g.
checkout@v7,setup-uv@v8,cache@v6, pinned upload/download-artifact and automatic-releases versions,pyright-action@v3).Reviewed by Cursor Bugbot for commit 6e9dac4. Configure here.