PCP-6119: feat: add AUTO link mode and LinkSubnetWithMode for MAAS link_subnet#43
Merged
AmitSahastra merged 5 commits intomainfrom Apr 7, 2026
Merged
PCP-6119: feat: add AUTO link mode and LinkSubnetWithMode for MAAS link_subnet#43AmitSahastra merged 5 commits intomainfrom
AmitSahastra merged 5 commits intomainfrom
Conversation
AmitSahastra
changed the title
AmitSahastra
commented
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds AUTO link mode support for MAAS network interface subnet linking and introduces a new Subnets client for listing subnets. The changes enable more flexible network interface configuration, particularly for managed subnets where MAAS can assign static IPs at deploy time without requiring DHCP on the wire.
Changes:
- Added
ModeAutoconstant and new methodsLinkSubnetWithMode,LinkSubnetWithForce, andUpdatefor network interfaces - Added
Subnetsclient withList()method to retrieve subnet information from MAAS - Added
CIDR()method toSubnetinterface to expose subnet CIDR information
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| maasclient/subnets.go | New file implementing Subnets client for listing MAAS subnets |
| maasclient/subnet.go | Added CIDR field and getter method to Subnet interface |
| maasclient/networkinterface.go | Added LinkSubnetWithMode, LinkSubnetWithForce, and Update methods; modified LinkSubnet to delegate to LinkSubnetWithMode |
| maasclient/constants.go | Added ModeAuto constant and updated mode documentation |
| maasclient/clientset.go | Added Subnets() method to ClientSetInterface |
| maasclient/client.go | Integrated Subnets controller into authenticatedClientSet |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AmitSahastra
commented
Apr 7, 2026
AmitSahastra
commented
Apr 7, 2026
AmitSahastra
commented
Apr 7, 2026
Kun483
changed the title
LinkSubnetWithMode (no force) and LinkSubnetWithForce (force=true)
Contributor
Author
|
@Kun483 new changes LGTM! |
AmitSahastra
changed the title
cPu1
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.