Updated Joinpoints.ts generation to integrate with Event System#68
Updated Joinpoints.ts generation to integrate with Event System#68racoelhosilva wants to merge 4 commits intostagingfrom
Conversation
| import eventListener from "./clava/events/EventListener.js"; | ||
| import { Event, EventTime } from "./clava/events/Events.js";\n\n` |
There was a problem hiding this comment.
The LARA framework should not know about the existence of Clava, which uses it. This is a sign that the events code currently in the Clava repository should be moved to the LARA framework repository, into the adequate folder.
I suggest moving moving the files to lara-framework/Lara-JS/src-api/lara/events and update imports accordingly.
There was a problem hiding this comment.
After looking at the code in PR#157, it is not immediately possible to move the code the the lara-framework, it would need further refactoring in order to separate the Events interface from the Clava-specific implementation.
|
Since this is still not a finished feature it should not be
merged into the staging branch.
Only when it ceases to be a WIP, could it be merged.
|
|
I recommend keeping the branch reference so the work isn't lost, but not merging as to not pollute the project with unfinished code. This is a good start but still has a long way to go. |
Updated Joinpoints.ts generation to integrate with Event System
References