Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changesets/1794851020-be0a6121.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
id: 1794851020-be0a6121
features:
- core
targets:
- cli
type: fix
bump: patch
description: the generated install.sh now quotes the temporary download directory in its EXIT trap, so cleanup removes only that directory and never runs path text as shell code
author: AshGodfrey
date: "2026-11-16"
12 changes: 6 additions & 6 deletions pkg/generate/snapshots/cli_release_go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -951,8 +951,8 @@ install_cli() {
log_info "Downloading from: $download_url"

# Create temporary directory
local tmp_dir=$(mktemp -d)
trap "rm -rf $tmp_dir" EXIT
tmp_dir=$(mktemp -d) || exit 1
trap 'rm -rf -- "$tmp_dir"' EXIT

# Download archive
if command -v curl >/dev/null 2>&1; then
Expand Down Expand Up @@ -2001,8 +2001,8 @@ install_cli() {
log_info "Downloading from: $download_url"

# Create temporary directory
local tmp_dir=$(mktemp -d)
trap "rm -rf $tmp_dir" EXIT
tmp_dir=$(mktemp -d) || exit 1
trap 'rm -rf -- "$tmp_dir"' EXIT

# Download archive
if command -v curl >/dev/null 2>&1; then
Expand Down Expand Up @@ -3110,8 +3110,8 @@ install_cli() {
log_info "Downloading from: $download_url"

# Create temporary directory
local tmp_dir=$(mktemp -d)
trap "rm -rf $tmp_dir" EXIT
tmp_dir=$(mktemp -d) || exit 1
trap 'rm -rf -- "$tmp_dir"' EXIT

# Download archive
if command -v curl >/dev/null 2>&1; then
Expand Down
4 changes: 2 additions & 2 deletions templates/templates/cli/release/install.sh.stmpl
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ install_cli() {
log_info "Downloading from: $download_url"

# Create temporary directory
local tmp_dir=$(mktemp -d)
trap "rm -rf $tmp_dir" EXIT
tmp_dir=$(mktemp -d) || exit 1
trap 'rm -rf -- "$tmp_dir"' EXIT

# Download archive
if command -v curl >/dev/null 2>&1; then
Expand Down
2 changes: 1 addition & 1 deletion zSDKs/sdk-cli/.speakeasy/gen.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions zSDKs/sdk-cli/scripts/install.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading