Repository navigation
fix(go,cli,mockserver,terraform): bump staticcheck to v0.8.2 for Go 1.27.2 - #214
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Bumps the staticcheck pin from v0.8.1 to v0.8.2 in the go, cli, mockserver, and terraform lint configs so post-generation lint works with Go 1.27.2. The -checks flags are unchanged and the pin is not emitted into generated output, making this a bounded tooling-version fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
698db82 to
31d11f7
Compare
Generator Snapshot Testing
Snapshot results: https://github.com/speakeasy-api/openapi-generation-snapshots/issues/167#issuecomment-6826719686 Snapshot results are summarized above. Additional run context is linked for maintainers with access. |
….27.2 Go 1.27.2 changed the compiler export data format. staticcheck v0.8.1 cannot read it, so the post-generation lint step failed with "export data version 5 is greater than maximum supported version 4" whenever the local toolchain was Go 1.27.2 or newer. staticcheck v0.8.2 (2026.2.2) supports the new format. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
31d11f7 to
a4407e1
Compare
Why
After generating a Go-based target, the generator lints the output with
go run honnef.co/go/tools/cmd/staticcheck@v0.8.1. Go 1.27.2 changed the compiler export data format, which staticcheck v0.8.1 cannot read, so with a Go 1.27.2+ toolchain the lint step fails and generation exits non-zero:Generation with Go 1.26.x is unaffected. staticcheck 2026.2.2 (v0.8.2) adds support for the Go 1.27.2 export data format.
What changed
v0.8.1tov0.8.2in the lint configuration of thego,cli,mockserverandterraformtargets. The-checksflags are unchanged.core/go, cli, mockserver, terraform, patch.The pin is only used by the generator's lint step and is not written into generated output, so the review SDKs do not change.
Testing
Each case generates from a small OpenAPI document and lets the generator run its own compile and lint steps.
v0.8.1)v0.8.2)gocliterraform(document with onex-speakeasy-entity)gowithgenerateTests/generateNewTests(SDK lint, then mock server lint)tests/mockservergostaticcheck v0.8.2 reported no new findings on any of the generated output above.
Not run locally, left to CI:
make lint,npm run format,make check-template-*, and the fullmake test-*suites against the larger test specs. The change is a version string inside existing string literals.Public-safety check
.claude/skills/public-repo-communication/SKILL.md).git diff --check.Summary by cubic
Bumps the
staticcheckpin from v0.8.1 to v0.8.2 in thego,cli,mockserver, andterraformtarget lint configurations. Go 1.27.2 changed the compiler export data format, which v0.8.1 cannot read, so the post-generation lint step failed with an export data version error whenever the local toolchain was Go 1.27.2 or newer; v0.8.2 supports the new format. Go 1.26.x is unaffected, and the-checksflags are unchanged. The pin only affects the generator's lint step and is not written into generated output, so generated SDKs do not change.Written for commit a4407e1. Summary will update on new commits.