Repository navigation
feat(terraform): honor const values on array and map properties #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AshGodfrey
wants to merge
26
commits into
main
Choose a base branch
from
ash/const-container-properties
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,018
−47
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
48234ba
feat(terraform): honor const values on array and map properties
AshGodfrey df8db20
fix: address review findings for container const support
AshGodfrey 5bd87c0
Merge remote-tracking branch 'origin/main' into ash/const-container-p…
AshGodfrey 554a3f1
Merge remote-tracking branch 'origin/main' into ash/const-container-p…
AshGodfrey 957323e
fix(terraform): validate container consts strictly and prove them end…
AshGodfrey c9f8bfc
chore: regenerate the review mockservers' JSON utils for structural c…
AshGodfrey 4108a85
fix(terraform): keep structural const comparison to containers and al…
AshGodfrey 9bc6357
chore: regenerate templates/perms.go with the go.mod toolchain
AshGodfrey e28dbe2
fix(terraform): render container const values with sorted keys
AshGodfrey 59635ea
chore: regenerate templates/perms.go with the go.mod toolchain
AshGodfrey 255cbc7
fix: keep a __proto__ key when sorting const map values
AshGodfrey 4039153
chore: merge the Terraform container const changesets
AshGodfrey 1178630
fix(go): decide container const comparison by field kind and type-che…
AshGodfrey 1f45e71
fix: accept an empty const on set-format and uniqueItems arrays
AshGodfrey 96bb176
fix(terraform): handle const containers nested in list items and temp…
AshGodfrey 8362a45
test(terraform): cover a const empty set on a delete body across API …
AshGodfrey 90088f8
test(terraform): assert a wrong response const fails decoding and har…
AshGodfrey 100b3a6
test(terraform): reject a delete request whose body cannot be read
AshGodfrey a70e3ed
fix: drop an empty container const when minItems is positive
AshGodfrey a2f81d9
fix: bound container consts by minItems and maxItems and accept null …
AshGodfrey 356dfe2
fix: decide container const optionality from parsed JSON tag options
AshGodfrey ff9eedd
fix: unwrap OptionalNullable when classifying and null-checking conta…
AshGodfrey 17e6159
test(terraform): cover nullable, escaped and parameter container consts
AshGodfrey 898b1c7
fix: omit container consts on content-based parameters too
AshGodfrey 2f90d00
Merge remote-tracking branch 'origin/main' into ash/const-container-p…
AshGodfrey 42e967f
Merge remote-tracking branch 'origin/main' into ash/const-container-p…
AshGodfrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| id: 1792662097-11a83540 | ||
| features: | ||
| - constArrays | ||
| - constObjects | ||
| targets: | ||
| - terraform | ||
| type: feat | ||
| bump: minor | ||
| description: array and map properties with a const value are hidden from the resource schema and the const value is sent in request bodies | ||
| author: AshGodfrey | ||
| date: "2026-10-22" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| id: 1792662097-2435dcc7 | ||
| features: | ||
| - constsAndDefaults | ||
| targets: | ||
| - go | ||
| - cli | ||
| type: fix | ||
| bump: patch | ||
| description: JSON unmarshaling compares array and map const values structurally instead of by exact text and treats null as absent for a container const | ||
| author: AshGodfrey | ||
| date: "2026-10-22" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.