fix(tui): keep user images as clickable placeholders - #227
Merged
Merged
Conversation
![kit-code-agent[bot]](https://avatars.githubusercontent.com/in/4797102?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
User-message layout now preserves textual placeholders and explicit newlines without reserving preview rows or scheduling image decoding. Existing link-bearing placeholders retain their click targets, and assistant/tool rendering remains separate. However, supported user images without a source URI lose their only image-viewing path.
Address review findings on the clickable placeholder flow: - Admission and link lookup now consult the opened pool, so a key retained by a click is neither materialized twice nor left as a kit-image label that re-decodes on every click. - Clicks resolve cached keys directly instead of cloning the source and round-tripping the image worker. - The image source limit toast fires once per session rather than on every later image-bearing message or resume replay. - A disconnected image worker reports "unavailable" instead of "busy; click again". - Drop the dead user-block image render arm and the vestigial placement tuple from user_block_rows. - Stop duplicating the 10 MiB materialization limit at the open site. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
danielkov
approved these changes
Sep 15, 2026
danielkov
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resource and interface behavior
Validation
mise run test -- --lib tui::: 466 passed, 1 ignored.mise run lint: passed formatting and Clippy for all-feature and no-default-feature configurations.git diff --check: passed.