Handle pre-3.0 specVersions in MultiFormatStore serialize guard.#139
Merged
goneall merged 1 commit intospdx:masterfrom Apr 2, 2026
Merged
Conversation
Member
|
@tiegz - I think you're right on this. I'm not sure how this made it past the unit tests. I'm going to do a bit of investigation on why the unit tests didn't catch this before merging. |
Member
|
Looks like I didn't have this particular method in the test cases Thanks @tiegz for the PR! |
goneall
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 42f69e2 a guard was added against the
specVersionwhile serializing. It checks ">= '3.0'", but before 3.0 specVersion values looked like "SPDX-2.3" (correct me if I'm wrong). This adds a regression test and fix for the older versions.This fixes a failure we ran into after upgrading to 2.0.5 of the library: