Update shipmonk/dead-code-detector to ^1.1#423
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the dev-only dead code analysis dependency used by the project’s PHPStan configuration.
Changes:
- Bumps
shipmonk/dead-code-detectorfrom^0.15.0to^1.1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spaze
force-pushed
the
spaze/dead-code-detector
branch
6 times, most recently
from
27b3d63 to
6acad9c
Compare
… dead-code-detector config Use the presence of `vendor/shipmonk/dead-code-detector/rules.neon` instead of `Composer\InstalledVersions::isInstalled()` instead. Because when PHPStan loads this config, the `InstalledVersions` class comes from `phpstan.phar` as PHPStan itself uses the detector, so it reflects PHPStan's own bundled dependencies rather than the project's installed packages. It was working before, because I've removed the detector only for `--prefer-lowest` dependencies, and PHPStan installed with `--prefer-lowest` wasn't using the detector yet, so it all worked.
spaze
force-pushed
the
spaze/dead-code-detector
branch
from
6acad9c to
fe9c1ba
Compare
…unsupported dependencies While the dead-code-detector package is not needed for PHPUnit, it still affects dependency resolution, and as it requires PHP 8.1+, a compatible dependency set would not be possible on older PHPs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.