Report real exit codes for Windows targets#125
Merged
Conversation
Add an onWindows() method that passes commands as an ssh argument instead of piping them to the remote shell via a heredoc. On Windows the remote shell is cmd.exe, which reads stdin differently and always exits 0, so isSuccessful() and getExitCode() never reflected a failed command. Passing the command as an argument runs it through cmd.exe /c, preserving the real exit code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124.
On a Windows target,
isSuccessful()always returnedtrueandgetExitCode()always0, even for failing commands. The package pipes commands to the remote shell through a heredoc, which relies onbash -seto propagate a failure. On Windows the remote shell iscmd.exe, which reads stdin differently, prints its banner/prompt into the output, and exits0regardless of what failed.This adds an
onWindows()method that passes the commands as an argument tosshinstead. Windows OpenSSH then runs them throughcmd.exe /c, so the real exit code is preserved and the prompt noise is gone.