Repository navigation
ci: add SonarCloud analysis and tighten build workflows - #9
Merged
Merged
Conversation
New workflow sonar_jdk17_ubuntu.yml runs the tests with JaCoCo coverage and the SonarCloud scanner on pushes to master, via the new sonarcloud profile in the parent pom.
- all workflows call ./mvnw, so the Maven version comes from the wrapper instead of the runner image - deploy skips forks and also runs on workflow_dispatch - build matrix adds JDK 21 on Ubuntu and Windows - CodeQL no longer checks out the font submodules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a SonarCloud analysis for figlet, set up like the ones in jackcess and ucanaccess, and tightens the existing workflows while at it.
The Sonar workflow runs the tests with JaCoCo coverage via a new sonarcloud profile, and only on pushes to master, so it won't run for this PR. Before merging, the project io.github.spannm:figlet needs to exist in SonarCloud and the SONAR_TOKEN secret has to be set.
The second commit switches all workflows to ./mvnw, so CI uses the Maven version from the wrapper instead of the one on the runner image. It also adds JDK 21 to the build matrix, keeps forks from running the deploy job and drops the font submodules from the CodeQL checkout.
The Windows jobs are the ones to watch: they now call ./mvnw through Git Bash.